Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 8, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
NHibernate (source) 5.4.8 -> 5.4.9 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-39677

Impact

A SQL injection vulnerability exists in some types implementing ILiteralType.ObjectToSQLString. Callers of these methods are exposed to the vulnerability, which includes:

  • Mappings using inheritance with discriminator values:
    • The discriminator value could be written in the mapping in a way exploiting the vulnerability of the associated discriminator type, if that type is among the vulnerable ones.
    • The current culture settings for formatting the discriminator value type could be altered in a way resulting into SQL injections with the discriminator values.
  • HQL queries referencing a static field of the application.
  • Users of the SqlInsertBuilder and SqlUpdateBuilder utilities, calling their AddColumn overload taking a literal value. These overloads are unused by NHibernate but could be used by users referencing directly these utilities.
  • Any direct use of the ObjectToSQLString methods for building SQL queries on the user side.

Patches

Releases 5.4.9 and 5.5.2.

Workarounds

  • Ensure the application does not use the features listed above.
  • For discriminator usages, ensure the discriminator values in the mappings do not contain quotes for string discriminators. Furthermore, for types which ToString conversion can be altered to include SQL injections through adequate hacking of the current culture settings, either change for another type, or ensure the used values cannot allow culture exploits, or ensure the application performs sanity checks of the current culture settings. Types sensitive to culture include integers for negative values, dates, times and datetimes, floats and decimals.

References

  • #​3516
  • #​3517
  • #​3547

Release Notes

nhibernate/nhibernate-core (NHibernate)

v5.4.9

Compare Source

=============================

Release notes - NHibernate - Version 5.4.9

6 issues were resolved in this release, including CVE-2024-39677.

** Bug

  • #​3547 Handle SQL injection vulnerabilities within ObjectToSQLString

** Task

  • #​3576 Release 5.4.9
  • #​3558 Migrate AppVeyor & TC builds to PostgreSQL 13
  • #​3545 Upgrade Npgsql to a non vulnerable version
  • #​3544 Upgrade vulnerable test dependencies
  • #​3517 Obsolete vulnerable literal AddColumn

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the build label Jul 8, 2024
@hazzik hazzik merged commit cff5fc8 into main Jul 8, 2024
@hazzik hazzik deleted the renovate/nuget-NHibernate-vulnerability branch July 8, 2024 21:27
@hazzik hazzik added this to the v3.4.0 milestone Jul 10, 2024
@hazzik hazzik added feature and removed build labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant