Skip to content

Mark Sql* methods on components as obsolete & hide it from editor #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Mark Sql* methods on components as obsolete & hide it from editor #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/FluentNHibernate/Mapping/ClasslikeMapBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ public ManyToManyPart<TChild> HasManyToMany<TChild>(Expression<Func<T, object>>
/// Specify an insert stored procedure
/// </summary>
/// <param name="innerText">Stored procedure call</param>
public StoredProcedurePart SqlInsert(string innerText)
public virtual StoredProcedurePart SqlInsert(string innerText)
{
return StoredProcedure("sql-insert", innerText);
}
Expand All @@ -410,7 +410,7 @@ public StoredProcedurePart SqlInsert(string innerText)
/// Specify an update stored procedure
/// </summary>
/// <param name="innerText">Stored procedure call</param>
public StoredProcedurePart SqlUpdate(string innerText)
public virtual StoredProcedurePart SqlUpdate(string innerText)
{
return StoredProcedure("sql-update", innerText);
}
Expand All @@ -419,7 +419,7 @@ public StoredProcedurePart SqlUpdate(string innerText)
/// Specify an delete stored procedure
/// </summary>
/// <param name="innerText">Stored procedure call</param>
public StoredProcedurePart SqlDelete(string innerText)
public virtual StoredProcedurePart SqlDelete(string innerText)
{
return StoredProcedure("sql-delete", innerText);
}
Expand All @@ -428,7 +428,7 @@ public StoredProcedurePart SqlDelete(string innerText)
/// Specify an delete all stored procedure
/// </summary>
/// <param name="innerText">Stored procedure call</param>
public StoredProcedurePart SqlDeleteAll(string innerText)
public virtual StoredProcedurePart SqlDeleteAll(string innerText)
{
return StoredProcedure("sql-delete-all", innerText);
}
Expand Down
15 changes: 15 additions & 0 deletions src/FluentNHibernate/Mapping/ComponentPartBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.ComponentModel;
using System.Diagnostics;
using System.Linq.Expressions;
using FluentNHibernate.MappingModel;
Expand Down Expand Up @@ -189,4 +190,18 @@ protected ComponentMapping CreateComponentMapping()

return mapping;
}

#pragma warning disable CS0809 // Obsolete member overrides non-obsolete member
[Obsolete("SqlInsert is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
public override StoredProcedurePart SqlInsert(string innerText) => base.SqlInsert(innerText);

[Obsolete("SqlUpdate is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
public override StoredProcedurePart SqlUpdate(string innerText) => base.SqlUpdate(innerText);

[Obsolete("SqlDelete is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
public override StoredProcedurePart SqlDelete(string innerText) => base.SqlDelete(innerText);

[Obsolete("SqlDeleteAll is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
public override StoredProcedurePart SqlDeleteAll(string innerText) => base.SqlDeleteAll(innerText);
#pragma warning restore CS0809 // Obsolete member overrides non-obsolete member
}