Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NHibernateLogger.GetNhibernateLoggerClass() throws NotImplementedException #1572

Closed
vgelmut opened this issue Feb 8, 2018 · 5 comments
Closed

Comments

@vgelmut
Copy link

vgelmut commented Feb 8, 2018

I have .NET Core 2.0 console app project (also there is asp.net core mvc and unit tests projects with same issues).
When installing NHibernate.Core from Nuget, I got this exception when trying to construct new Nhibernate.Cfg.Configuration().

Decompiling sources showing that NHibernateLogger static constructor contains call to:

 private static string GetNhibernateLoggerClass()
 {
    throw new NotImplementedException();
 }

When reviewing the sources on Github, this method contains normal code instead.

P.S. Reproduced on different machines, so there is no decompiling or platform specific code issue.

@fredericDelaporte
Copy link
Member

NHibernate.Core is neither owned nor supported by the NHibernate team. Please contact the NuGet owner of the package instead.

@fredericDelaporte
Copy link
Member

I have furthermore sent this message to the owner:

Hello,

I am among NHibernate owners. Due to following support ticket, I discover your NHibernate.Core NuGet package.

#1572

I do not know if the NHibernate name is registered or not and if you have right to use its name as you have done here.

But at the very least you should change the properties of the package for making it clear this not an official .Net Core version of NHibernate.
Please change or remove http://nhibernate.info/.
Please modify the description/summary for stating this is a .Net Core port of your own (or derived from some other work like the pending PRs we have, if that is the case).

Regards,

Frédéric Delaporte

@vgelmut
Copy link
Author

vgelmut commented Feb 8, 2018

Thanks for the answer. I was really sure it's official.

What are the plans to move to .net core? I'm really expecting this for all my projects to upgrade to. Don't want to move to EF core

@fredericDelaporte
Copy link
Member

There is #633 and #1523.
#633 is a PR from @ngbrown, awaiting since long but not considered valid by one owner, see its #1425 and #626 dependencies (and also this comment here; I have not checked this subject).

#1523 is a PR from @hazzik willing to provide .Net Core support with minimal changes. WIP.

There is also an issue, #954, but there is no significant activity there.

@annymsMthd
Copy link

We've been using #633 in production for a few weeks now with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants