-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate appveyor build to MySql 8 #3447
Migrate appveyor build to MySql 8 #3447
Conversation
According to this SO answer, it seems we must use at least MySql.Data 8.0.30 for recent MySql servers. We are using the 8.0.27 one. |
86c20bb
to
57a346b
Compare
All MySql builds fail now, downgrading from 8.2.0 to 8.0.33. There is some issues with lock tests and 8.2.0. |
@fredericDelaporte .33 will fail as well. In #3095 (comment):
|
Most are form 8.0, some older.
@fredericDelaporte, this is the issue: #1302 |
I would suggest to quote |
Doesn't look like it to me. #1302 is about using Also if I understand correctly some new words are now reserved in MySql 8 (like groups) and we don't do auto-quoting by default in tests. So failed tests are expected to me - we need to quote new reserved words or register new words + enable auto-qouting in affected test cases. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
So, I could either enable auto-quoting on that test, or drop the change and directly quote that new reserved word. |
This reverts commit 7cfe3f9.
Add OrderBy to ambiguous queries
Replaced by #3453 |
This is an attempt to fix the appveyor build. MySql 5.7 seems to have disappeared from the appveyor images without notice. We would have to use MySql 8 instead.
See appveyor/ci#3895.