Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate appveyor build to MySql 8 #3447

Closed

Conversation

fredericDelaporte
Copy link
Member

This is an attempt to fix the appveyor build. MySql 5.7 seems to have disappeared from the appveyor images without notice. We would have to use MySql 8 instead.

See appveyor/ci#3895.

hazzik
hazzik previously approved these changes Nov 19, 2023
@fredericDelaporte
Copy link
Member Author

According to this SO answer, it seems we must use at least MySql.Data 8.0.30 for recent MySql servers. We are using the 8.0.27 one.

@fredericDelaporte
Copy link
Member Author

All MySql builds fail now, downgrading from 8.2.0 to 8.0.33. There is some issues with lock tests and 8.2.0.

@hazzik
Copy link
Member

hazzik commented Nov 21, 2023

@fredericDelaporte .33 will fail as well.

In #3095 (comment):

@bahusoid: Looks like v8.0.30 is the latest working version.

hazzik and others added 2 commits November 22, 2023 07:56
Most are form 8.0, some older.
@hazzik
Copy link
Member

hazzik commented Nov 23, 2023

@fredericDelaporte, this is the issue: #1302

@hazzik
Copy link
Member

hazzik commented Nov 23, 2023

I would suggest to quote groups table in this test case for the purpose of this ticket, and drop the keywords from here.

@bahusoid
Copy link
Member

bahusoid commented Nov 24, 2023

@fredericDelaporte, this is the issue: #1302

Doesn't look like it to me. #1302 is about using Configuration.GenerateSchemaCreationScript directly (not via SchemaExport) in user code. But quoting is not executed there, instead SchemaExport.Create should be used (that's the only place when auto-quote setting is applied). Am I missing something?

Also if I understand correctly some new words are now reserved in MySql 8 (like groups) and we don't do auto-quoting by default in tests. So failed tests are expected to me - we need to quote new reserved words or register new words + enable auto-qouting in affected test cases.

@hazzik

This comment was marked as resolved.

@bahusoid

This comment was marked as resolved.

@hazzik

This comment was marked as resolved.

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Nov 25, 2023

So, I could either enable auto-quoting on that test, or drop the change and directly quote that new reserved word.

@fredericDelaporte fredericDelaporte removed this from the 5.5 milestone Nov 30, 2023
@fredericDelaporte
Copy link
Member Author

Replaced by #3453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants