Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency issues on TransactionScope timeout #3483

Merged
merged 22 commits into from
Mar 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f245b8f
Add a test case for system transactions timeout
fredericDelaporte Feb 2, 2024
7df425a
Fix concurrency issues on TransactionScope timeout
fredericDelaporte Feb 3, 2024
c1ab2eb
Fix the fix
fredericDelaporte Feb 6, 2024
df14163
Fix corrupted character
fredericDelaporte Feb 6, 2024
01e97ae
Still attempt to release the session even if in use
fredericDelaporte Feb 7, 2024
fa20807
Generate async files
github-actions[bot] Feb 7, 2024
1a71fc1
Apply review
fredericDelaporte Feb 8, 2024
440807b
Allow more control of synchronization failures
fredericDelaporte Feb 8, 2024
79b9f03
Generate async files
github-actions[bot] Feb 8, 2024
2da9e3a
Fix typos
fredericDelaporte Feb 8, 2024
53e01f7
Downgrade the log to Warn
fredericDelaporte Feb 9, 2024
e26e53e
Lock explicitly
fredericDelaporte Feb 13, 2024
9ec5821
Handle the case of concurrent session disposal
fredericDelaporte Feb 13, 2024
20ec428
Fix whitespace
fredericDelaporte Feb 21, 2024
f0fd7f4
Remove the crutch for a very unlikely concurrency possibility
fredericDelaporte Feb 21, 2024
3d54b26
Add more information on unclosed session
fredericDelaporte Feb 25, 2024
d9bcbee
Remove another concurrency issue possibility
fredericDelaporte Feb 25, 2024
78639a6
The crutch has to come back
fredericDelaporte Feb 26, 2024
06013ad
Revert "The crutch has to come back"
fredericDelaporte Feb 27, 2024
f212f1a
Avoid having a flaky SupportsTransactionTimeout test
fredericDelaporte Feb 28, 2024
d72795c
Generate async files
github-actions[bot] Feb 28, 2024
8042475
Fix teardown
fredericDelaporte Feb 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lock explicitly
Instead of relying on concurrent session usages to do it through BeginProcess.
fredericDelaporte committed Feb 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit e26e53e5bc3a2fc7593ddc0448f1405a32eb0370
Original file line number Diff line number Diff line change
@@ -484,6 +484,7 @@ protected virtual void CompleteTransaction(bool isCommitted)
// do an early exit here in such case.
if (!IsInActiveTransaction)
return;
Lock();
var isSessionProcessing = _session.IsProcessing();
try
{