fix: circular selection with keyboard (#2), #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jung-han
reviewed
May 21, 2021
src/js/dropdown.js
Outdated
Comment on lines
273
to
276
| index += direction + length; | ||
| index %= length; | ||
|
|
||
| return index; |
There was a problem hiding this comment.
return (index + direction + length) % length; 한줄로 줄일 수 있을 것 같네요
jungeun-cho
reviewed
May 21, 2021
src/js/dropdown.js
Outdated
| for (; index < items.length && index >= 0; index += direction) { | ||
| index = this.getItemIndex(index, length, direction); | ||
|
|
||
| while (index < length && index >= 0) { |
js87zz
reviewed
May 21, 2021
Comment on lines
+68
to
+69
| // 'IE11', | ||
| // 'Edge', |
There was a problem hiding this comment.
테스트가 정상 진행되지 않아 주석처리 했습니다.
IE11의 경우 테스트를 수행하고자 하는 흔적(브라우저가 켜져 있는 등)이 있으나 Error response status: 13, UnknownError - An unknown server-side error occurred while processing the command.를 출력하며 테스트가 정상 진행되지 않았습니다.
따라서 주석 처리 후 IE11 상에서 동작 테스트를 대신 진행했습니다.
js87zz
reviewed
May 21, 2021
| * @param {number} direction - direction to move | ||
| * @return {number} | ||
| */ | ||
| getItemIndex(index, length, direction) { |
There was a problem hiding this comment.
public API로 나가는거에요? 그럴만한 메서드가 아닌 것 같아서요
There was a problem hiding this comment.
JSDoc 삭제해서 올리겠습니다!
chore: remove unnecessary contidion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
as-is
to-be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨