Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Conversation

frovere
Copy link

@frovere frovere commented Sep 6, 2019

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Because event listeners inside DOM templates will be automatically transformed to lowercase (due to HTML’s case-insensitivity) is recommend use kebab-case for event names.

https://vuejs.org/v2/guide/components-custom-events.html#Event-Names


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@frovere frovere force-pushed the feat/kebab-event-listeners branch from 357fd48 to 2538826 Compare September 6, 2019 16:17
@frovere frovere force-pushed the feat/kebab-event-listeners branch from 2538826 to 25d42c9 Compare September 6, 2019 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant