This repository was archived by the owner on Apr 6, 2020. It is now read-only.
fix: missing exts option and invoke method in the Viewer (close: #16) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohee-lee7
changed the title
dongwoo-kim
reviewed
Mar 27, 2019
| 'y.max: 40', | ||
| 'y.suffix: $', | ||
| '```' | ||
| ].join('\n'); |
There was a problem hiding this comment.
템플릿 리터럴을 사용할 순 없을까요?
개별 라인을 문자열로 처리하니까 작성하기도 어렵고 가독성도 썩 좋지 않은 것 같아서요.
There was a problem hiding this comment.
머지가 되고 나니 갑자기 드는 생각인데..
그냥 마크다운 파일로 저장하고, raw-loader 로 읽어와도 될 것 같습니다 ㅎ
dongwoo-kim
reviewed
Mar 27, 2019
stories/editor.stories.js
Outdated
| '@change="onChange"', | ||
| '@stateChange="onStateChange"', | ||
| '/>' | ||
| ].join(' '), |
There was a problem hiding this comment.
여기 템플릿도 스트링 리터럴을 사용하면 좋을 것 같아요. 인덴트가 크게 중요하진 않으니까요.
만약 신경쓰인다면 common-tags의 stripIndent 같은 거 사용해도 되구요.
There was a problem hiding this comment.
넵 변경하겠습니다. 감사합니다.
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
extsoption of the Viewer. (fix: How can I use exts with Viewer? #16)invokemethod in the Viewer.Thank you for your contribution to TOAST UI product. 🎉 😘 ✨