-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rangeSelection feature on LineType, Column Chart #763
Changes from 4 commits
59bb59d
72d0075
339d29b
5ec8020
0f3e626
4578437
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ import HoveredSeries from '@src/component/hoveredSeries'; | |
import DataLabels from '@src/component/dataLabels'; | ||
import Tooltip from '@src/component/tooltip'; | ||
import Background from '@src/component/background'; | ||
import RangeSelection from '@src/component/rangeSelection'; | ||
import NoDataText from '@src/component/noDataText'; | ||
|
||
import * as basicBrush from '@src/brushes/basic'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기는 |
||
|
@@ -171,6 +172,7 @@ export default class ColumnLineChart extends Chart<ColumnLineChartOptions> { | |
this.componentManager.add(HoveredSeries); | ||
this.componentManager.add(SelectedSeries); | ||
this.componentManager.add(DataLabels); | ||
this.componentManager.add(RangeSelection); | ||
this.componentManager.add(Tooltip, { chartEl: this.el }); | ||
this.componentManager.add(NoDataText); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ import Title from '@src/component/title'; | |
import ExportMenu from '@src/component/exportMenu'; | ||
import SelectedSeries from '@src/component/selectedSeries'; | ||
import HoveredSeries from '@src/component/hoveredSeries'; | ||
import Zoom from '@src/component/zoom'; | ||
import RangeSelection from '@src/component/rangeSelection'; | ||
import Background from '@src/component/background'; | ||
import NoDataText from '@src/component/noDataText'; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기도 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이건 Zoom 기능 지원이 제대로 안되는 차트인데 들어가 있었네요. 이번 PR에선 빼고 zoom 처리를 다시 확인해봐야겠어요. (추가) |
||
|
@@ -146,7 +146,7 @@ export default class LineScatterChart extends Chart<LineScatterChartOptions> { | |
this.componentManager.add(HoveredSeries); | ||
this.componentManager.add(SelectedSeries); | ||
this.componentManager.add(Tooltip, { chartEl: this.el }); | ||
this.componentManager.add(Zoom); | ||
this.componentManager.add(RangeSelection); | ||
this.componentManager.add(NoDataText); | ||
|
||
this.painter.addGroups([ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
설명이 사라졌네요