Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Select events by using mobile(#26) #27

Merged
merged 3 commits into from
Mar 26, 2019
Merged

fix: Select events by using mobile(#26) #27

merged 3 commits into from
Mar 26, 2019

Conversation

jung-han
Copy link
Member

@jung-han jung-han commented Mar 21, 2019 •
edited
Loading

#26

  • 모바일일 경우 touchend 이벤트만 사용. 아닐 경우 click 이벤트 사용

seonim-ryu
seonim-ryu approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[3/25] 리뷰 완료합니다. 개인적으로 제이쿼리 걷어내면 좋겠..네요ㅎ

@jung-han
Copy link
Member Author

ok to test

junghwan-park
junghwan-park reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[3/25] 완료입니다~~ 고생 많았어요 ㅎㅎ

@jung-han jung-han merged commit fd60cd8 into master Mar 26, 2019
@jung-han jung-han deleted the fix/touchend-event branch March 26, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junghwan-park junghwan-park junghwan-park left review comments

@seonim-ryu seonim-ryu seonim-ryu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jung-han @junghwan-park @seonim-ryu