Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove drop-down layer of editor #1545

Merged
merged 9 commits into from
Jan 7, 2022
Merged

fix: remove drop-down layer of editor #1545

merged 9 commits into from
Jan 7, 2022

Conversation

jajugoguma
Copy link
Contributor

@jajugoguma jajugoguma commented Jan 6, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Fixed editor drop-down layers not disappearing in situations such as cancelEditing API calls, grid re-rendering, etc.

As-is

To-Be

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

adhrinae
adhrinae approved these changes Jan 6, 2022
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

lja1018
lja1018 approved these changes Jan 6, 2022
View reviewed changes
Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

packages/toast-ui.grid/src/view/editingLayer.tsx Outdated Show resolved Hide resolved
jwlee1108
jwlee1108 approved these changes Jan 6, 2022
View reviewed changes
Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

packages/toast-ui.grid/src/view/editingLayer.tsx Outdated Show resolved Hide resolved
js87zz
js87zz approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 고생하셨어요!

packages/toast-ui.grid/src/view/editingLayer.tsx Outdated Show resolved Hide resolved
packages/toast-ui.grid/src/editor/select.ts Outdated
@@ -17,14 +17,14 @@ import { includes, isNil, pixelToNumber } from '../helper/common';
export class SelectEditor implements CellEditor {
public el: HTMLDivElement;

public isMounted = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그리고 참고로 타입에 public은 빼도 될 것 같습니다. 이전에는 무조건 다 public을 넣었는데 굳이 그럴 필요가 없어보여서요. 참고 부탁드려요!

packages/toast-ui.grid/src/view/editingLayer.tsx Outdated Show resolved Hide resolved
Base automatically changed from fix/editor-with-drop-down-layer to master January 7, 2022 10:25
@jajugoguma jajugoguma merged commit 13947c1 into master Jan 7, 2022
@jajugoguma jajugoguma deleted the fix/remove-drop-down-layer-of-editor branch January 7, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

@jwlee1108 jwlee1108 jwlee1108 approved these changes

@lja1018 lja1018 lja1018 approved these changes

@adhrinae adhrinae adhrinae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jajugoguma @adhrinae @lja1018 @jwlee1108 @js87zz