feat: add APIs that return added class names #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwlee1108
approved these changes
Jan 21, 2022
packages/toast-ui.grid/src/grid.tsx
Outdated
| const { rawData } = this.store.data; | ||
| const classNamesOfFirstRow: string[] = rawData[0]._attributes.className.column[columnName]; | ||
|
|
||
| if (!isEmpty(classNamesOfFirstRow)) { |
There was a problem hiding this comment.
확실히 calendar에서 쓰는 isPresent 같은 긍정 조건이 더 좋아보이긴 하네요.
(+추가)
혹시 이런 건 어떨까요..?
if(isEmpty()) {
return [];
}
return rawData.slice(1).reduce();
adhrinae
approved these changes
Jan 21, 2022
| return rawData.slice(1).reduce((acc, row, _, arr) => { | ||
| const classNames = row._attributes.className.column[columnName]; | ||
|
|
||
| if (isEmpty(classNames) || isEmpty(acc)) { |
There was a problem hiding this comment.
isEmpty(acc) 부분은 위에서 이미 걸러지는거 아닌가요?
그리고 아래에서 arr.splice(0) 를 하게되는 이유가 궁금해지네요.
There was a problem hiding this comment.
아래쪽의 return acc.filter((className) => includes(classNames, className));을 보시면 아시겠지만, 기본 동작이 첫 행이 가지고 있는 ClassNames에서 다른 행들은 가지고 있지 않는 ClassNames를 제외하는 방식으로 구현 되어있습니다.
이 과정에서, 만약 모든 ClassName이 제거된다면(컬럼에 할당한 ClassName이 없다면) 더 이상 loop를 수행할 이유가 없어져서 이를 확인하기 위해 isEmpty(acc)를 추가했습니다.
그리고 Array.reduce는 네 번재 인자로 전달되는 배열에 대해 수행되기 때문에 더 이상 loop를 수행할 필요가 없어진 경우 이 배열을 변형해 조기 종료를 수행하기 위해 arr.splice(0)를 수행했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨