-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented resize functionality fix #100, #342 #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contributing.
It's very cool feature :)
However, the icon can be modified because we have our designer.
Once again, thank you for the contributing!!
… Removed unnecesary css style: .{prefix}-submenu-align-mr-0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing. :)
I have two questions.
First of all, one test is being broken(npm run test
command). Can you fix it? And could you add a test for resize
?
Second, what would be the copyright on the icon you added? If there is no copyright issue, I think I will use it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution :) 👍
|
Added all tests @lja1018 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank yor for your contribution. 👍 👍 👍
I have some questions.
- Should I add the image source to
README
? - Please add 1 line to
component/resize
(import { Promise } from '@/util';
). Required for old browser support :)
|
@seytar |
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨