Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: api examples to es6 #60

Merged
merged 5 commits into from
May 28, 2021
Merged

chore: api examples to es6 #60

merged 5 commits into from
May 28, 2021

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Change examples in api document(jsdoc) and README to ES6
  • Prettier table of contents in README

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma requested review from heenakwag and lja1018 May 28, 2021 01:10
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

https://nhn.github.io/tui.time-picker/latest/TimePicker#event-change
여기도 화살표함수 적용하면 좋을 것 같습니다.

* var timepicker = new tui.TimePicker('#timepicker-container', {
* import TimePicker from 'tui-time-picker'; // ES6
* // or const TimePicker = require('tui-time-picker'); // CommonJS
* // or var TimePicker = tui.TimePicker;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여긴 var가 있네요~ 여기도 const로 수정해주세요.

Copy link

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var가 보이네요~ 확인부탁합니다.

@jajugoguma jajugoguma merged commit b491bdd into master May 28, 2021
@jajugoguma jajugoguma deleted the fix/api-examples-to-es6 branch May 28, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants