Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/130-clean-eslint-prettier #137

Closed

Conversation

rochejul
Copy link
Contributor

@rochejul rochejul commented Sep 29, 2020

Description

The ideas:

  1. ensure to have all expected eslint dependencies
  2. ensure to have only one eslint configuration
  3. align between eslint and prettier configuration

Motivation and Context

Pull request for issue #130

How Has This Been Tested?

Simply run the following command:

npm install
npm run lint

You should have currently one warning because one variable is not used

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nhoizey
Copy link
Owner

nhoizey commented Oct 4, 2020

@rochejul appart from the comment I made, this looks great, thanks!

@TheSench
Copy link
Collaborator

I messed up the merge (pasted package.lock over top of package.json) and am having issues editing this branch outside of GitHub (everything I do locally ends up creating separate branches). Going to clean it up locally later this week.

@TheSench
Copy link
Collaborator

I have recreated this PR under #217 (still attributing rochejul for the changes, but addressing merge conflicts in package.json via rebasing). Additionally, it's now updated to use ESLint 8 instead of 6.

@TheSench TheSench closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants