New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default value of scope as 'email name' #39

Merged

nhosoya merged 1 commit into nhosoya:master from btalbot:add-scope-default

Jun 19, 2020

+2 −1

Contributor

btalbot commented Jun 18, 2020

Make default scope what I believe is the most common and expected value of 'email name'. User can still over ride as desired of course.


          add default value of scope as 'email name'

9264dd0

btalbot mentioned this pull request

undefined method `present?' for nil:NilClass (NoMethodError) #34

Closed

Owner

nhosoya commented Jun 19, 2020

I agree with you.
Many users will expect email name, those who don't will explicitly specify the scope.

nhosoya approved these changes

View reviewed changes

nhosoya merged commit 3715b10 into nhosoya:master

btalbot deleted the add-scope-default branch

June 19, 2020 02:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet