This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
Switch to aws_s3_bucket_lifecycle_configuration
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing Terraform attempting to remove the following on every run:
- server_side_encryption_configuration {
- rule {
- bucket_key_enabled = false -> null
- apply_server_side_encryption_by_default {
- sse_algorithm = "AES256" -> null
}
}
}
Upgrading the AWS Provider to v4 should fix this.
Before we can upgrade to v4 we need to switch to using
aws_s3_bucket_lifecycle_configuration
Previous declaration was deprecated: ``` Terraform 0.13 and earlier allowed provider version constraints inside the provider configuration block, but that is now deprecated and will be removed in a future version of Terraform. To silence this warning, move the provider version constraint into the required_providers block. ```
adrianclay
force-pushed
the
upgrade-terraform-version-gp2gp
branch
2 times, most recently
from
7e0cc0a to
c246384
Compare
The list function has been deprecated since 0.12 [1], so replace with tolist. [1]: https://developer.hashicorp.com/terraform/language/functions/list
adrianclay
force-pushed
the
upgrade-terraform-version-gp2gp
branch
4 times, most recently
from
a53355d to
8346e49
Compare
Fixes issue where Terraform complains about S3 lifecycle rules needing updating when no terraform has changed.
adrianclay
force-pushed
the
upgrade-terraform-version-gp2gp
branch
from
8346e49 to
7e57f59
Compare
ole4ryb
approved these changes
Nov 6, 2023
MartinWheelerMT
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing Terraform attempting to remove the following on every run:
This PR uses
aws_s3_bucket_lifecycle_configuration, and updates Terraform, and AWS Terraform to a version where this is no longer an issue.