Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRMP 1036 - Fix PDF Intermittence #204

Merged
merged 32 commits into from
Oct 31, 2024
Merged

PRMP 1036 - Fix PDF Intermittence #204

merged 32 commits into from
Oct 31, 2024

Conversation

RioKnightleyNHS
Copy link
Contributor

No description provided.

abbas-khan10
abbas-khan10 previously approved these changes Oct 24, 2024
@@ -1,6 +1,6 @@
module "cloudfront-distribution-lg" {
source = "./modules/cloudfront/"
bucket_domain_name = "${terraform.workspace}-${var.lloyd_george_bucket_name}.s3.amazonaws.com"
bucket_domain_name = "${terraform.workspace}-${var.lloyd_george_bucket_name}.s3.eu-west-2.amazonaws.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var.aws_region?

Copy link

@chrisbloe-nhse chrisbloe-nhse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a custom policy. This will help us get better error logging.

@RioKnightleyNHS RioKnightleyNHS merged commit 1d1e5b0 into main Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants