PRMP-640 #11
Merged
PRMP-640 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbas-khan10
reviewed
Aug 7, 2024
joefong-nhs
reviewed
Aug 8, 2024
| gp_dynamo_item.update( | ||
| actions=[ | ||
| PracticeOds.supplier_name.set(requesting_supplier_name), | ||
| PracticeOds.supplier_last_updated.set(datetime.now()), |
There was a problem hiding this comment.
Could we check whether the supplier_last_updated should be of date type or datetime type?
I see that we use date.today() above (which output date type), and we have datetime.now() here (which output datetime type) .
When I tried compare date and datetime in local terminal it gave an error:
>>> datetime.now() < date.today()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: can't compare datetime.datetime to datetime.date
There was a problem hiding this comment.
If you try datetime.now().date() < date.today() it should be ok.
We convert datetime to date in line 179 😄
| if supplier_name is None: | ||
|
|
||
| if supplier_name is None: | ||
| print( |
There was a problem hiding this comment.
Are we able to add logger here instead of print?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.