PRMT-4467 #145
Merged
PRMT-4467 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject` - added additional validation
martin-nhs
requested review from
MohammadIqbalAD-NHS,
AndyFlintNHS and
chrisbloe-nhse
JoeSykesNHS
reviewed
Feb 2, 2024
JoeSykesNHS
reviewed
Feb 2, 2024
JoeSykesNHS
approved these changes
Feb 2, 2024
JoeSykesNHS
reviewed
Feb 2, 2024
|
|
||
| def new_uuid() -> str: | ||
| return str(uuid.uuid4()) | ||
| if len(file_lines) > 1: |
There was a problem hiding this comment.
bit pedantic so feel free to ignore:
I would separate this validation out into a separate function under the class and then calls Class.read() and then class.validate_one_line()
JoeSykesNHS
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_object.