Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unused scss classes from breadcrumbs #943

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Removes unused scss classes from breadcrumbs #943

merged 2 commits into from
Jun 10, 2024

Conversation

anandamaryon1
Copy link
Collaborator

Description

Removes nhsuk-icon__chevron-right and nhsuk-icon__chevron-left classes, as they seem to be unused by the breadcrumbs component, which uses a :before and :after class, which styles the chevrons.

Checklist

@anandamaryon1 anandamaryon1 requested a review from Fenwick17 April 30, 2024 08:45
@anandamaryon1 anandamaryon1 merged commit a64b5cb into main Jun 10, 2024
2 checks passed
@anandamaryon1 anandamaryon1 deleted the remove-unused-scss-breadcrumbs branch June 10, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fenwick17 Fenwick17 Fenwick17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandamaryon1 @Fenwick17