Remove .nhsuk-u-top-and-bottom utility class #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this utility class, as it's not actually included within the frontend build (and hasn't been for a while) and the mixin seems to be mostly intended for internal use within other components rather than to be used standalong as a utility class.
frankieroberto
force-pushed
the
remove-top-and-bottom-utility-class
branch
from
9662318 to
7baa327
Compare
|
Hi @roshaanbajwa, were you going to check this one? |
roshaanbajwa
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted that the
.nhsuk-u-top-and-bottomutility class isn't actually included within the build as it was removed fromcore/all.scssin 2018 (df303c1).From the looks of it, the
top-and-bottom()mixin was likely only intended for use within other components, and I can’t see any evidence of it having been used as a standalone utility class (see GitHub search.So I think this is safe to remove?
Checklist