Add 36 to type scale and swap headings to use it #989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our typography scale, the large size seems smaller than necessary. On GOV.UK it's 36px, whereas in NHS it's 32px. Once our heading guidance is updated, we may see more headings using the large size, so I am proposing updating our type scale to use 36px rather than 32px.
The GOV.UK scale goes:
NHS:
To swap the size would likely be a breaking change - users may be relying on the
.nhsuk-u-font-size-32
classes or passing 32 to the font mixins.I am proposing adding 36 to the scale and updating the heading mixins to use it, and leave 32 for now. We can then remove 32 from the scale at the next major version.
Checklist