Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task list component and pattern #2031

Closed
wants to merge 16 commits into from
Closed

Conversation

edwardhorsford
Copy link
Contributor

@edwardhorsford edwardhorsford commented Sep 12, 2024

Description

Adds the task list component and pattern. These are largely copied verbatim from the GOV.UK Design System, though I have made updates to refer to NHS, make the examples more relevant, or where our colour scheme differs.

As the NHS Frontend component PR hasn't been merged, this PR targets that pr in package.json. This should be removed prior to this PR being merged. For testing, you can pull this branch and run npm install and it should pick up the other work.

It's possible the component / pattern should be mentioned / listed in other bits of the app - I tried to insert it in all the places by checking where another pattern was mentioned, but it's possible I've missed places.

Component guidance

Task list - NHS digital service manual · 11 59am · 09-16

Pattern guidance

Complete multiple tasks - NHS digital service manual

Updated tag colour examples

The tag component shows some example statuses - but these don't align with what the task list pattern uses. I've updated the two conflicting ones to align with what we and GOV.UK have.

Before After
Screenshot 2024-09-16 at 11 54 21 Screenshot 2024-09-16 at 11 55 01

Related issue

This wants to be merged alongside the companion nhsuk-frontend pr adding the task list component.

Checklist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit off-topic for this PR maybe but, I notice we have two example of an 'Active' tag, one with the default dark blue and one with nhsuk-tag--aqua-green. The task list should see more usage of these status tags so perhaps we should fix them?

@cjforms
Copy link

cjforms commented Oct 1, 2024

The task list guidance is awash with 'should' - a word that is ambiguous and does not clearly say what the reader must or must not do.

I'm happy to try to provide a version without 'should' in it but could someone give me a hand about how to do that?

Here's a specific example:
"In a task list, the user should be able to choose to complete tasks in any order that works for them."

This is somewhat incorrect, as typically users can choose some tasks straight away but others may not be available yet.

Solved by changing it to:
"In a task list, the user can see which tasks they have to do and can choose tasks that are available in any order that words for them".

@cjforms
Copy link

cjforms commented Oct 1, 2024

The guidance says "Do not use the task list for a long service that needs to be completed in a specific order. If it needs to be completed over multiple sessions, consider allowing users to save their progress, and then to continue where they left off when they return. Use the start page to explain what users will be expected to do during the service."

This is not correct. With appropriate content design, a task list will give users a sense of their overall progress in long services, irrespective of whether the service needs to be completed in a particular order. I've seen testing where the report has been 'the task list did not help here' where in fact the problem was that the content design was poor.

My suggestion is to remove this paragraph.

@edwardhorsford
Copy link
Contributor Author

The guidance says "Do not use the task list for a long service that needs to be completed in a specific order. If it needs to be completed over multiple sessions, consider allowing users to save their progress, and then to continue where they left off when they return. Use the start page to explain what users will be expected to do during the service."

This is not correct. With appropriate content design, a task list will give users a sense of their overall progress in long services, irrespective of whether the service needs to be completed in a particular order. I've seen testing where the report has been 'the task list did not help here' where in fact the problem was that the content design was poor.

My suggestion is to remove this paragraph.

Strong agreement on this. Task list is the ideal thing to help navigate things that need to happen in a specific order.

@anandamaryon1
Copy link
Contributor

Myself and @sarawilcox made some content changes in this commit: fdf75cb

In summary:

  • Loosen the wording around only using the task list for multi-session transactions, thinking that one user's 'single sitting' is another's multiple sittings.
  • Loosen the wording around choosing the order, to include "where possible", as sometimes a certain order is needed, which was already hinted at with the 'cannot start yet' status, and mentioned in the pattern but not task list.
  • Removed the GOV research on this component and linked to theirs instead.

Feedback welcomed.

@sarawilcox
Copy link
Contributor

@sarawilcox sarawilcox closed this Nov 7, 2024
@anandamaryon1
Copy link
Contributor

Released via another branch and PR in release 7.2.0

@anandamaryon1 anandamaryon1 deleted the add-task-list branch November 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 2024 - Done
Development

Successfully merging this pull request may close these issues.

4 participants