-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task list component and pattern #2031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit off-topic for this PR maybe but, I notice we have two example of an 'Active' tag, one with the default dark blue and one with nhsuk-tag--aqua-green
. The task list should see more usage of these status tags so perhaps we should fix them?
The task list guidance is awash with 'should' - a word that is ambiguous and does not clearly say what the reader must or must not do. I'm happy to try to provide a version without 'should' in it but could someone give me a hand about how to do that? Here's a specific example: This is somewhat incorrect, as typically users can choose some tasks straight away but others may not be available yet. Solved by changing it to: |
The guidance says "Do not use the task list for a long service that needs to be completed in a specific order. If it needs to be completed over multiple sessions, consider allowing users to save their progress, and then to continue where they left off when they return. Use the start page to explain what users will be expected to do during the service." This is not correct. With appropriate content design, a task list will give users a sense of their overall progress in long services, irrespective of whether the service needs to be completed in a particular order. I've seen testing where the report has been 'the task list did not help here' where in fact the problem was that the content design was poor. My suggestion is to remove this paragraph. |
Strong agreement on this. Task list is the ideal thing to help navigate things that need to happen in a specific order. |
Myself and @sarawilcox made some content changes in this commit: fdf75cb In summary:
Feedback welcomed. |
Released today: |
Released via another branch and PR in release 7.2.0 |
Description
Adds the task list component and pattern. These are largely copied verbatim from the GOV.UK Design System, though I have made updates to refer to NHS, make the examples more relevant, or where our colour scheme differs.
As the NHS Frontend component PR hasn't been merged, this PR targets that pr in
package.json
. This should be removed prior to this PR being merged. For testing, you can pull this branch and runnpm install
and it should pick up the other work.It's possible the component / pattern should be mentioned / listed in other bits of the app - I tried to insert it in all the places by checking where another pattern was mentioned, but it's possible I've missed places.
Component guidance
Pattern guidance
Updated tag colour examples
The tag component shows some example statuses - but these don't align with what the task list pattern uses. I've updated the two conflicting ones to align with what we and GOV.UK have.
Related issue
This wants to be merged alongside the companion nhsuk-frontend pr adding the task list component.
Checklist
package.json
(using SEMVER)