Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support page and link and tweaked the about page #149

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vickytnz
Copy link
Contributor

@vickytnz vickytnz commented Nov 24, 2024

New support page
support page with details of slack channels

About page changed

Before After
Before about page after about page with contribution section changed

Footer

Example Image
Before footer link - with About and support  NHS prototype kit on GitHub Cookies
After footer link with About  Support  NHS prototype kit on GitHub  Cookies

@vickytnz vickytnz linked an issue Nov 24, 2024 that may be closed by this pull request
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-91-create--gs3yw9 November 24, 2024 18:15 Inactive
@vickytnz vickytnz marked this pull request as ready for review November 24, 2024 18:15
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions.

app/views/support.html Outdated Show resolved Hide resolved
app/views/support.html Outdated Show resolved Hide resolved
app/views/support.html Outdated Show resolved Hide resolved
app/views/about.html Show resolved Hide resolved
vickytnz and others added 3 commits November 25, 2024 16:37
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
@vickytnz vickytnz temporarily deployed to nhs-prototyp-91-create--gs3yw9 November 25, 2024 16:38 Inactive
Copy link
Contributor Author

@vickytnz vickytnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes make sense

Copy link
Contributor Author

@vickytnz vickytnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes accepted

@vickytnz
Copy link
Contributor Author

New support page
new support page

About page changed

Before After
Before about page changed about page with link to support

Footer

Example Image
Before footer link - with About and support  NHS prototype kit on GitHub Cookies
After footer link with About  Support  NHS prototype kit on GitHub  Cookies

@frankieroberto
Copy link
Contributor

@vickytnz just realised the 2 slack links need different link text for accessibility reasons. Any ideas?

@vickytnz
Copy link
Contributor Author

vickytnz commented Nov 25, 2024

@vickytnz just realised the 2 slack links need different link text for accessibility reasons. Any ideas?

@frankieroberto Ah yeah that's why in the original one I led with the Slack instance as is does make a difference for some people which one to use. I actually I think on the second we can get rid of the NHS service manual option.

  • NHS England #prototype-kit channel
  • service manual #prototype-kit channel

We are supposed to follow the 'if ... then' format so if we need anything more than the header at the start then we probably need to roll back to explaining who can use which instance

@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-91-create--gs3yw9 November 25, 2024 18:25 Inactive
@frankieroberto
Copy link
Contributor

@vickytnz have tweaked slightly. How’s this:

support-page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a standalone page for Support
2 participants