Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout when disconnecting connector in Windows #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikhalim
Copy link
Collaborator

No description provided.

Signed-off-by: Kevin Khai-Wern Lim <khai-wern.lim@ni.com>
@ericgross2
Copy link
Contributor

This might have some side effects. I think there is a supported pattern where you can call send() and then disconnect and be guaranteed that the sends are completed before the disconnect happens. By adding this short timeout it might cause data to be lost in this case.

I’m a little unclear what causes the original problem. Is it possible there is queued send data?

@nikhalim
Copy link
Collaborator Author

That's what I'm afraid of when adding the timeout. However, I couldn't think of another way to get the EventHandler thread to exit when Disconnect is called. For some odd reason, this situation occurs only when RDMA Close is called on Windows's listener session and Linux's delays closing its connector session. I could not reproduce this situation with both Windows, both Linux nor Windows connecting to Linux.

Is there a way for me to identify whether there's any queued send data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listener's session in Windows waits until Connector's session in Linux is closed
2 participants