Fix sync tests to what is expected #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reckenro
approved these changes
May 7, 2024
Yeah, I can't see your change affecting this. Didn't see a Bug/Issue either so created one: #1058 |
astarche
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Some of the sync system tests have been failing for a while. Specifically the ones that check for errors. This is probably because they require real hardware and are not ran as part of the CI.
I updated the tests to work as expected with the current implementation. It appears that #692 did some changes where the error and message is reported through the grpc status instead of the response status. Updated the tests work with those changes.
Why should this Pull Request be merged?
Fixes sync tests so we can rely on their output to identify issues with any changes.
What testing has been done?
built and ran tests locally.