Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native concurrency functionality and separate CI and PR actions #1104

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

maxxboehme
Copy link
Collaborator

@maxxboehme maxxboehme commented Oct 9, 2024

What does this Pull Request accomplish?

Migrate to using the native concurrency functionality provided by github actions. This migration was suggested by the styfle/cancel-workflow-action we were using in their README.

Also created a separate ci.yml and pr.yml for easier sorting when looking at the actions tab. This also mimics what other projects like nidaqmx-python and measurement-plugin-labview follow. This also makes it clear on the rules that for PR builds if another action is kicked off it would cancel the previous while the same is not true for CI builds.

Why should this Pull Request be merged?

  • Clear division of CI and PR builds
  • Migrate to using native github action functionality for canceling multiple PR jobs running at once for the same PR.

What testing has been done?

PR build

@maxxboehme maxxboehme marked this pull request as ready for review October 9, 2024 21:57
Copy link
Collaborator

@reckenro reckenro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. When you're ready to submit you'll need to change main branch's protection policies to switch over the required checks to the new ones.

@maxxboehme
Copy link
Collaborator Author

Updated required checks for both "main" and "releases" branches.

@maxxboehme maxxboehme merged commit 783f038 into ni:main Oct 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants