Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify commands for NILRT build and use Ninja #1106

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

maxxboehme
Copy link
Collaborator

@maxxboehme maxxboehme commented Oct 11, 2024

What does this Pull Request accomplish?

  • Remove extra steps that were in the build process that were not needed.
  • Running many of the build steps that were running cmake through cmake for no extra benefit
    • Some when building were trying to find the error messages and report that out. This can be added later if needed
  • Standardize on the way to reference variables.
  • Use Ninja as generator to match Windows and Ubuntu builds. Along with using SimenB/github-actions-cpu-cores so we can utilize all the cores provided by the build machine when building. This had an 18% speed up improvement.

Why should this Pull Request be merged?

Simplify the build steps so that setup and configuration of the build can easily be followed for personal setup.

What testing has been done?

  • PR Build
    • Made sure that the created artifacts match what the latest CI build created.

@maxxboehme maxxboehme marked this pull request as ready for review October 14, 2024 16:31
@maxxboehme maxxboehme merged commit 027569f into ni:main Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants