-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for sideband streaming #1113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asumit
requested review from
astarche,
reckenro and
maxxboehme
as code owners
October 24, 2024 21:28
asumit
requested review from
rajendra-desai-ni,
doshirohan,
ccifra and
Aldo633
and removed request for
rajendra-desai-ni
October 24, 2024 21:29
astarche
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to look at this again after you have answered my questions and gotten feedback from at least 1 other reviewer.
astarche
approved these changes
Oct 29, 2024
asumit
commented
Oct 29, 2024
astarche
approved these changes
Oct 31, 2024
doshirohan
reviewed
Nov 3, 2024
doshirohan
approved these changes
Nov 4, 2024
maxxboehme
requested changes
Nov 4, 2024
astarche
approved these changes
Nov 6, 2024
maxxboehme
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds infrastructure to add streaming support for respective driver apis.
We are adding moniker service source files directly in this repo as a stop gap to enable submission of driver specific
streaming support. We would reference the source files directly from the sideband repo as a subsequent PR and remove thse from the source in the grpc-device repo.
The streaming functionality is aided by the grpc-sideband implementation that is added as a submodule to the grpc-device repo.
This PR build is subject to succesful completion of 2 PRs on the grpc-sideband repo
int64_t -> int and size_t -> int
grpc-device is expected to link statically against the sideband lib
The following changes are present in this PR.
Why should this Pull Request be merged?
What testing has been done?
Driver specific streaming apis will be added later. hence testing is only done to ensure that the moniker service is up and running and clients are able to call BeginSidebandStream without error.
Regular driver api for daq works fine as it is.