daqmx: Pick up scrapigen daqmx metadata update #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siu Fong Tan <siu.fong.tan@ni.com>
Signed-off-by: Siu Fong Tan <siu.fong.tan@ni.com>
SiuFong-NI
requested review from
reckenro,
astarche and
maxxboehme
as code owners
zhindes
previously requested changes
Nov 5, 2024
maxxboehme
requested changes
Nov 6, 2024
bkeryan
reviewed
Nov 6, 2024
maxxboehme
added
the
source-breaking
Updated in latest commit, verified that generated files excluded CalculatedPower related stuff. |
SiuFong-NI
dismissed
zhindes’s stale review
Updated in latest commit, verified that generated files excluded CalculatedPower related stuff.
1 task
zhindes
approved these changes
Nov 7, 2024
bkeryan
approved these changes
Nov 7, 2024
maxxboehme
approved these changes
Nov 7, 2024
reckenro
approved these changes
Nov 7, 2024
|
Pending grpc-device-scrapigen https://github.com/ni/grpc-device-scrapigen/pull/251 to be merged before merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Pull latest scrapigen daqmx metadata from this PR: daqapi: Add new attribute and enum value for mioDAQ configurable digital voltage
Why should this Pull Request be merged?
This is needed to make sure the grpc-device repo proto gen for any changes with the updated metadata.
What testing has been done?
Local build successfully.