add pstore-save, replacing nieficleanvars fixup script #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amstewart
reviewed
Jun 18, 2021
amstewart
requested changes
Jun 18, 2021
There was a problem hiding this comment.
All looks good; apart from the minor clarification request above.
Also, could you add the ptest package to the smoke packagegroup. It doesn't matter at this stage, but I'd like to have it enumerated there, so that we don't forget to enable it when we build out the ptest infrastructure.
shruthi-ravi
approved these changes
Jun 19, 2021
"pstore-save" is a utility script that retrieves information out of "pstore", a persistent storage interface for the kernel to store "last breath" crash information before rebooting. The nilrt kernel has been storing this information for some time now (as per the default kernel configuration). It is inspired in large parts by systemd-pstore, added in systemd 248, but since the nilrt distro is not presently using systemd, this implemention avoids the systemd dependencies. A ptest is also added. Since we obviously would prefer to avoid crashing the kernel from a ptest, it uses cached data generated from a sysrq-triggered crash on qemu. Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
…ariables on boot" Now that we have pstore-save which can properly store and clean up these variables, we don't need this fixup script anymore. This reverts commit 196d987. Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
amstewart
approved these changes
Jun 21, 2021
|
Approved. Let me know when you're ready for merge, @bstreiff . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a better solution to dealing with the buildup of EFI variables created by
efi-pstore, add a new script,pstore-save, to actually save off the dmesg data from prior boots. This works similarly (although not identically) to howsystemd-pstorewould if configured to save to local files and not the journal.It may be possible to leverage this for ARM (using the
ramoopsbackend for pstore) but our targets are not presently configured to useramoops, so this is only being enabled for x64.This obsoletes the
nieficleanvarsscript.