Add a hardknott recovery media image recipe #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved safemode-restore-image into recipes-core/images. Removed safemode-image recipe and merged its contents into safemode-restore-image. Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
We no longer build safemode-restore-image by fetching packages from internal shares. So remove the code. Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The "restore image" and "restore mode" terminology has mixed meanings and can be confused for long-deprecated NILRT features. It is also not clear to a modern user that these targets represent the installation/recovery media ISO. Refactor the safemode-restore-image recipe to nilrt-recovery-image, for clarity. Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The hardknott recovery media image is 'nilrt-recovery-image'. Other images called '*restore*' are deprecated images; remove them to reduce confusion. Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The LVComms image variant is no longer a distinct image type for NILRT and no pipeline should be building it. Remove these image recipes to reduce the chance for confusion. Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The `minimal-nilrt-*` image recipes were used when NILRT-NXG existed as a distinct image variant. Since CG and NXG were consolidated, these targets are no longer used and should not be built by any pipeline. Remove the deprecated recipes to avoid confusion. Signed-off-by: Alex Stewart <alex.stewart@ni.com>
shruthi-ravi
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an image recipe
nilrt-recovery-image, which installs the modern, hardknott safemode image to unprovisioned targets. It also removes the historic and confusingly namedrestore-images and the deprecated, historiclvcommsandminimalrecipes.This PR replaces ni/meta-nilrt PR #276.
There is more work to do on the
images/directory, but it is not as relevant to getting the recovery media pipeline online, so can be deferred to later.Testing
This recipe builds on my dev machine's nicentral repo. I did not bother checking the deprecated images, for obvious reasons.
@ni/rtos