Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hardknott] Fix parsing failures in packagegroup-ni-extra #290

Merged
merged 28 commits into from
Jan 4, 2022

Conversation

amstewart
Copy link
Contributor

During the sumo-hardknott rebase, many recipes that were a part of the extra packagegroup broke when they were dropped upstream. Since we don't guarantee the extra feed contents (and build it with --continue) it wasn't a blocking issue. This PR tries to fix those errors and make the -extra packagegroup at least buildable.

  1. Many recipes in packagegroup-ni-extra were removed, because they were dropped by yocto upstream and I couldn't find any justification for their inclusion in the feed. (NOTE: anywhere in the commits I say "no discrete requirement", I mean that they seemed to be included arbitrarily.)
  2. The florence recipe was broken, and had previously been migrated to meta-nilrt after it was dropped by yocto upstream. Since then, we have identified other virtual keyboard solutions that we would prefer to use in hardknott. So I removed florence and libglade.
  3. Added a static uid/gid for FreeRadius, which allows bitbake to actually build that package family. It is a low-level dependency for many packages in the packagegroup-core-security group, so that fixed many recipes from that layer.
  4. nirtcfg-tests was broken due to a grammatical error in the recipe. I fixed it.

I have more -extra packagegroup recipe fixups I would like to put in (removing the nilrt/nilrt-nxg split, et c.), but they are unrelated to the goals of this patchset.

Testing

I can now perform parsing operations like bitbake -e and bitbake -g on the -extra packagegroup. I haven't tried to build it on my dev machine, since we don't guarantee it like that. But I will monitor the extra feed build once this is accepted.

@ni/rtos

Update the packagegroup SUMMARY to make clear that NI doesn't "support"
the package contents of the extra feed.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Recipes `ossp-uuid` and `wireless-tools` have been removed from OE-core, as
of yocto thud, and there are no other providers.

Upstream recommends that `ossp-uuid` dependers switch to `uuid.h`
provided by `util-linux`.

Upstream recommends that `wireless-tools` dependers switch to `iw`.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Upstream OE-core has declared foomatic-filters as obsolete, and it was
removed in the dunfell release.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Some python modules which were translated to python3 have no buildable
providers; remove them.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
`engine-pkcs11` has been removed from meta-oe. Upstream recommends that
it has been "merged into libp11".

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
t1lib has been removed by upstream meta-oe due to low use.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The `eventlog` recipe has been removed upstream; they recommend that it
has been "integrated into syslog-ng".

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Upstream meta-oe removed dnssec-conf because it depends on python2 code
which "was not updated since 2010."

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The start-stop-daemon package is "an older version" of what is in the
`dpkg-start-stop` package. It is no longer provided by meta-oe.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
ipsec-tools has been removed by meta-oe upstream. ipsec upstream is
apparently dead and not recommended for continued use.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
`udisks` has been removed from meta-oe in favor of the newer `udisks`
recipe. However, the new package requires the `polkit` DISTRO_FEATURE,
which NILRT does not provide.

Remove udisks from pkggrp-ni-extra, in absense of a discrete
requirement.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Upstream meta-oe has deprecated the older `sip` recipe, and replaced it
with `sip3`. In the absence of a discrete requirement, remove the
dependency.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
@amstewart
Copy link
Contributor Author

Patch V2

  • Clean rebase on latest hardknott mainline ref.

The mprpc module has been deprecated upstream. The NI RFMI team is
already aware of the deprecation and tracking the work to move their
drivers to use gRPC.

Remove the dependency, because it is unbuildable in hardknott.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
OE upstream dropped python-webdav without replacement, when they dropped
the other python2 recipes. In absence of a discrete requirement, drop
the package from -extra.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Removing more python3 packages which lack buildable providers in
upstream.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
OE-core commit 8c9fad86d8bd86f13d61a1a5cd65d12b16a9e0de removed the
polkit recipe, based on an assertion that it isn't default anymore, it
has been integrated into meta-gnome, and that future versions will
require javascript runtime elements which are not embedded-friendly.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
umip no longer has an upstream provided recipe. Remove it, in absence of
a discrete requirement.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The nostromo upstream is dead, and meta-oe has dropped the recipe
associated with it.

Cherokee depends on meta-python2, which NILRT hardknott does not
provide; remove it.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The `futures` module is a standard part of python3 and python3-futures
does not exist.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
There is no upstream python3-mox recipe. There is a python3-mox3 recipe.
But neither has a discrete requirement, so remove them both.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The feedparser python module requires python2, and so has been removed
from upstream OE.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The mysql-python bindings require python2 and so are marked for deletion
in upstream. In absence of a discrete requirement to keep this package,
remove it from the feed.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Sysprof has a dependency on `polkit`. Since it has been deprecated in
upstream and removed, it cannot be built. Remove it in absence of a
discrete requirement.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Florence virtual keyboard has been removed by yocto upstream, and NIRLT
has a desire to replace it with something more maintainable. Remove it
from the hardknott feeds.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
libglade was only really depended upon by `florence`, which has been
removed. Remove libglade, since it has a dead upstream.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The nirtcfg-tests-ptest RDEPENDS_append did not include a prefixed space
character, so was clobbering the RDEPENDS list, resulting in a
parse-failure in the nirtcfg-tests recipe.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
The freeradius project recipes require a system uid/gid. Freeradius is a
dependency of the meta-security packagegroup-core-security group, which
is a part of the extra feed.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
@amstewart amstewart force-pushed the dev/hardknott/extra branch from e10352d to 21fc7dd Compare January 3, 2022 14:14
@amstewart
Copy link
Contributor Author

Patch V3

  • s/myrpc/mprpc/ in the pkggrp-ni-extra: remove python3-mprpc commit. @shruthi-ravi

@amstewart amstewart merged commit 3087e31 into ni:nilrt/master/hardknott Jan 4, 2022
@amstewart amstewart deleted the dev/hardknott/extra branch January 4, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants