Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpam: add NI-specific pamd.d/other file #435

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

amstewart
Copy link
Contributor

NILRT prefers to handle the default PAM authentication behavior
differently from OE-core upstream. Previously, NILRT maintained an
out-of-stream commit to set the values of the pam.d/other file. This
commit was reverted from OE-core.

Move the NI-specific other file to meta-nilrt as-is.

Signed-off-by: Alex Stewart alex.stewart@ni.com

Natinst AZDO ID: #1580104

Testing

  • Rebuilt the libpam package with this change, and verified that the libpam-runtime:/etc/pam.d/other conffile has the NI-specific values.

Maintainership

  • Depends on OE-core #64.

NILRT prefers to handle the default PAM authentication behavior
differently from OE-core upstream. Previously, NILRT maintained an
out-of-stream commit to set the values of the `pam.d/other` file. This
commit was reverted from OE-core.

Move the NI-specific `other` file to meta-nilrt as-is.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
@amstewart amstewart requested review from shruthi-ravi and a team July 20, 2022 20:51
Copy link
Contributor

@shruthi-ravi shruthi-ravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other PR, verify login works as expected in the image.

@amstewart
Copy link
Contributor Author

Testing

  • Built a new VM with this change and booted into safemode. Getty still allows login via admin as expected, and disallows login via anything else.

@shruthi-ravi shruthi-ravi merged commit 44e195e into ni:nilrt/master/hardknott Jul 26, 2022
@amstewart amstewart deleted the dev/hardknott/pam branch July 27, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants