niconfigpersistentlogs: add init script to configure persistent logs #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As installed, /var/log is a symlink to /var/volatile/log which is located on a tmpfs mount. As a result, logs are lost on each reboot. This change provides a simple way for users to change logs to be persistent across reboots for debugging purposes and to change back again. Signed-off-by: Jeffrey Pautler <jeffrey.pautler@ni.com>
amstewart
requested changes
Sep 20, 2022
| PERSISTENT_DIR_VAR_LOG_LINE="d root root 0755 /var/log none" | ||
| VOLATILE_SYMLINK_VAR_LOG_LINE="l root root 0755 /var/log /var/volatile/log" | ||
|
|
||
| ENABLE_PERSISTENT_LOGS_INI_VAL=$(/usr/local/natinst/bin/nirtcfg --get section=SystemSettings,token=PersistentLogs.enabled,value="false" | tr "[:upper:]" "[:lower:]") |
There was a problem hiding this comment.
New guidance is to rely on PATH to evaluate your binaries. So $(nirtcfg ...) is preferred.
There was a problem hiding this comment.
Did you change it? It looks the same to me.
recipes-ni/niconfigpersistentlogs/niconfigpersistentlogs_1.0.bb
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeffrey Pautler <jeffrey.pautler@ni.com>
Signed-off-by: Jeffrey Pautler <jeffrey.pautler@ni.com>
shruthi-ravi
approved these changes
Sep 22, 2022
amstewart
reviewed
Sep 23, 2022
recipes-ni/ni-configpersistentlogs/ni-configpersistentlogs_1.0.bb
Outdated
Show resolved
Hide resolved
| PERSISTENT_DIR_VAR_LOG_LINE="d root root 0755 /var/log none" | ||
| VOLATILE_SYMLINK_VAR_LOG_LINE="l root root 0755 /var/log /var/volatile/log" | ||
|
|
||
| ENABLE_PERSISTENT_LOGS_INI_VAL=$(/usr/local/natinst/bin/nirtcfg --get section=SystemSettings,token=PersistentLogs.enabled,value="false" | tr "[:upper:]" "[:lower:]") |
There was a problem hiding this comment.
Did you change it? It looks the same to me.
amstewart
requested changes
Sep 23, 2022
recipes-ni/ni-configpersistentlogs/ni-configpersistentlogs_1.0.bb
Outdated
Show resolved
Hide resolved
…ariable Signed-off-by: Jeffrey Pautler <jeffrey.pautler@ni.com>
Signed-off-by: Jeffrey Pautler <jeffrey.pautler@ni.com>
amstewart
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As installed, /var/log is a symlink to /var/volatile/log which is located on a tmpfs mount. As a result, logs are lost on each reboot. This change provides a simple way for users to change logs to be persistent across reboots for debugging purposes and to change back again.
Signed-off-by: Jeffrey Pautler jeffrey.pautler@ni.com