Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "conf/distro/nilrt.inc: Set PACKAGE_ENABLE_FILELIST="True"" #474

Conversation

chaitu236
Copy link
Contributor

@chaitu236 chaitu236 commented Oct 3, 2022

There don't seem to be any uses of Packages.filelist.

NI's PACKAGE_ENABLE_FILELIST implementation is being removed from
oe-core. So remove setting PACKAGE_ENABLE_FILELIST here.

This reverts commit 5295e17.

Testing

Added a local feed that has no Packages.filelist, added it to a target installed a package from the feed and ran opkg search for a file in the package - it still worked.

opkg search operations don't work for files not installed on a target so I don't see how Packages.filelist is useful.

Will port this to sumo branches once we have a bit of runtime on hardknott and determined that nothing is affected.

@chaitu236 chaitu236 requested a review from a team October 3, 2022 23:48
@amstewart
Copy link
Contributor

The PACKAGE_ENABLE_FILELIST mechanism is an NI-ism that hasn't been upstreamed. So can we just revert this out-of-stream commit in OE-core?

There don't seem to be any uses of Packages.filelist.

NI's PACKAGE_ENABLE_FILELIST implementation is being removed from
oe-core. So remove setting PACKAGE_ENABLE_FILELIST here.

This reverts commit 5295e17.

Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
@chaitu236 chaitu236 force-pushed the dev/cvadrevu/PACKAGE_ENABLE_FILELIST branch from 82560cf to 3311fd1 Compare October 4, 2022 19:55
@chaitu236 chaitu236 changed the title nilrt.inc: Don't set PACKAGE_ENABLE_FILELIST Revert "conf/distro/nilrt.inc: Set PACKAGE_ENABLE_FILELIST="True"" Oct 4, 2022
@chaitu236
Copy link
Contributor Author

The PACKAGE_ENABLE_FILELIST mechanism is an NI-ism that hasn't been upstreamed. So can we just revert this out-of-stream commit in OE-core?

Created ni/openembedded-core#70 reverting ni/openembedded-core@6b91cf9.
Also updated this PR to just revert 5295e17.

@amstewart amstewart merged commit 0583c13 into ni:nilrt/master/hardknott Oct 4, 2022
@chaitu236 chaitu236 deleted the dev/cvadrevu/PACKAGE_ENABLE_FILELIST branch October 4, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants