Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util-linux: busybox dependency to squash warning #505

Merged
merged 1 commit into from
Dec 8, 2022
Merged

util-linux: busybox dependency to squash warning #505

merged 1 commit into from
Dec 8, 2022

Conversation

dylan-matthew-turner
Copy link
Contributor

Getting a warning where util-linux-hwclock (which is RPROVIDES by util-linux) depends on busybox-hwclock (RDEPENDS by busybox):

WARNING: util-linux-2.37.4-r0 do_package_qa: QA Issue: util-linux-hwclock rdepends on busybox-hwclock, but it isn't a build dependency, missing busybox in DEPENDS or PACKAGECONFIG? [build-deps]

Adding a dependency here squashes warning

@dylan-matthew-turner
util-linux: busybox dependency to squash warning
383564b 
Getting a warning where util-linux-hwclock (which is RPROVIDES by
util-linux) depends on busybox-hwclock (RDEPENDS by busybox)

Adding a dependency here squashes warning

Signed-off-by: Dylan Turner <dylantdmt@gmail.com>
@amstewart
Copy link
Contributor

That doesn't seem right. util-linux-hwclock should replace busybox-hwclock, not depend on it. What is the reason for the dependency? Is it the /etc/init.d/hwclock initscript?

@dylan-matthew-turner
Copy link
Contributor Author

It is due to the util-linux_2.%.bbappend file containing: RDEPENDS:${PN}-hwclock:append = " niacctbase busybox-hwclock"

@dylan-matthew-turner
Copy link
Contributor Author

I'll try removing the busybox-hwclock dependency as an alternative

@amstewart
Copy link
Contributor

Yeah; I think that's for the /etc/init.d/hwclock script. Maybe we can't get rid of the RDEPENDS, but I'm still not sure that the :class-target is the correct override for the DEPENDS.

@dylan-matthew-turner
Copy link
Contributor Author

Removing busybox-hwclock from the RDEPENDS doesn't appear to cause any errors when running bitbake util-linux

@amstewart
Copy link
Contributor

It wouldn't; it's a runtime dependency.

@amstewart
Copy link
Contributor

We discussed this PR offline, and I'm now in agreement.

@amstewart amstewart merged commit f5e478b into ni:nilrt/master/kirkstone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amstewart amstewart amstewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylan-matthew-turner @amstewart