Enable create-spdx when building images. #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkingSpork
suggested changes
Apr 18, 2023
amstewart
requested changes
Apr 18, 2023
Under DISTRO_FEATURES, all features listed used spaces not tabs except virtualization. Make it consistent with the rest of the formatting Signed-off-by: Dylan Turner <dylan.turner@ni.com>
Enable create-spdx by inheriting the class and set it to run on image creation by adding it to the distro feature set Signed-off-by: Dylan Turner <dylan.turner@ni.com>
dylan-matthew-turner
force-pushed
the
enable-spdx
branch
from
73553b7 to
4b655dc
Compare
|
I moved the changes to nilrt.conf from nilrt.inc (and thus also split the INHERIT), but I left a change in nilrt.inc to convert one tab in a string of spaces to all spaces for the sake of consistency. I rebuilt after moving, and the spdx is still being created |
SparkingSpork
approved these changes
Apr 18, 2023
amstewart
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we now skip creating SPDX when a package comes from a remote feed, we can enable creating the spdx zst archives when building images.
To enable it, we need to inherit from create-spdx at the top-level bitbake config, and add it to the list of DISTRO_FEATURES.
I verified this produces the expected archive by building
packagefeed-ni-corefollowed bynilrt-base-system-image