-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bolt #605
Merged
amstewart
merged 3 commits into
ni:nilrt/master/kirkstone
from
chaitu236:dev/cvadrevu/bolt_review
Aug 16, 2023
Merged
Add bolt #605
amstewart
merged 3 commits into
ni:nilrt/master/kirkstone
from
chaitu236:dev/cvadrevu/bolt_review
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tbtadm as it is being replaced by bolt Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
chaitu236
commented
Aug 4, 2023
2 tasks
amstewart
requested changes
Aug 7, 2023
recipes-bsp/bolt/bolt/0001-Update-udev-rule-for-hosts-that-don-t-have-systemd.patch
Outdated
Show resolved
Hide resolved
51cd294
to
d080444
Compare
amstewart
requested changes
Aug 14, 2023
recipes-bsp/bolt/bolt/0001-daemon-support-running-without-PolicyKit.patch
Show resolved
Hide resolved
d080444
to
2aa718f
Compare
v2: Remove polkit from REQUIRED_DISTRO_FEATURES as it was added to meta-oe PR per upstream's feedback. |
This commit contains following changes required for bolt to work - Patch from upstream to allow running bolt without polkit - Patch to allow all commands to be run without authorization (making way for dbus to handle authorization). - dbus rules to allow only admin to run privileged commands of boltctl - udev rule to remove dependency on systemd and start boltd directly. udev rule useful in cases where thunderbolt device is connected after host boots. - initscript to start boltd only when thunderbolt devices are present on the host. initscript useful in cases where thunderbolt device is already connected when host boots and udev isn't able to start boltd because it runs before dbus (a dependency for boltd). - Wrapper around boltctl so it runs with LANG set to UTF-8 in order to display non-ASCII characters correctly. Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
2aa718f
to
bcb908a
Compare
v3: Added Upstream-Status |
amstewart
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add bolt support in nilrt.
WI: 2093177
Testing
Tested on PXIe-8861 connected to PXIe-8301 with a PXI-6683H in same chassis.
With changes from meta-openembedded ni/meta-openembedded#41,
bolt
package.boltd
is started by initscript if thunderbolt device is connected before boot up.boltd
is not started if thunderbolt device isn't connected before boot up.boltd
is started by udev if thunderbolt device is connected after boot up.enroll
ed device is authorized automatically by bolt whether thunderbolt device is connected before/after host is booted.boltctl
argumentsauthorize
,forget
,list
work as expected.