Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bolt #605

Merged
Merged

Conversation

chaitu236
Copy link
Contributor

@chaitu236 chaitu236 commented Aug 4, 2023

These commits add bolt support in nilrt.

WI: 2093177

Testing

Tested on PXIe-8861 connected to PXIe-8301 with a PXI-6683H in same chassis.

With changes from meta-openembedded ni/meta-openembedded#41,

  • Built bolt package.
  • Verified that boltd is started by initscript if thunderbolt device is connected before boot up.
  • Verified boltd is not started if thunderbolt device isn't connected before boot up.
  • Verified that boltd is started by udev if thunderbolt device is connected after boot up.
  • Verified that enrolled device is authorized automatically by bolt whether thunderbolt device is connected before/after host is booted.
  • Verified other boltctl arguments authorize, forget, list work as expected.

Remove tbtadm as it is being replaced by bolt

Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
@chaitu236 chaitu236 requested a review from a team August 4, 2023 02:44
recipes-bsp/bolt/bolt/bolt Outdated Show resolved Hide resolved
recipes-bsp/bolt/bolt/boltctl Show resolved Hide resolved
recipes-bsp/bolt/bolt_%.bbappend Show resolved Hide resolved
recipes-bsp/bolt/bolt/bolt Show resolved Hide resolved
recipes-core/packagegroups/packagegroup-ni-desirable.bb Outdated Show resolved Hide resolved
conf/distro/nilrt.inc Outdated Show resolved Hide resolved
@chaitu236 chaitu236 force-pushed the dev/cvadrevu/bolt_review branch from 51cd294 to d080444 Compare August 14, 2023 18:44
@chaitu236 chaitu236 requested a review from amstewart August 14, 2023 18:46
@chaitu236 chaitu236 force-pushed the dev/cvadrevu/bolt_review branch from d080444 to 2aa718f Compare August 15, 2023 18:23
@chaitu236
Copy link
Contributor Author

v2: Remove polkit from REQUIRED_DISTRO_FEATURES as it was added to meta-oe PR per upstream's feedback.

This commit contains following changes required for bolt to work

 - Patch from upstream to allow running bolt without polkit
 - Patch to allow all commands to be run without authorization (making
   way for dbus to handle authorization).
 - dbus rules to allow only admin to run privileged commands of boltctl
 - udev rule to remove dependency on systemd and start boltd
   directly. udev rule useful in cases where thunderbolt device is
   connected after host boots.
 - initscript to start boltd only when thunderbolt devices are present
   on the host. initscript useful in cases where thunderbolt device is
   already connected when host boots and udev isn't able to start boltd
   because it runs before dbus (a dependency for boltd).
 - Wrapper around boltctl so it runs with LANG set to UTF-8 in order to
   display non-ASCII characters correctly.

Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
@chaitu236 chaitu236 force-pushed the dev/cvadrevu/bolt_review branch from 2aa718f to bcb908a Compare August 15, 2023 21:14
@chaitu236
Copy link
Contributor Author

v3: Added Upstream-Status

@amstewart amstewart merged commit ca729b5 into ni:nilrt/master/kirkstone Aug 16, 2023
@chaitu236 chaitu236 deleted the dev/cvadrevu/bolt_review branch August 16, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants