initscripts-nilrt: add LV RT cgroup version detection to init scripts #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing
|
|
@rtollert not sure why I can't add you to the reviewers list but I would like your input on this PR. |
amstewart
approved these changes
Aug 30, 2023
chaitu236
approved these changes
Sep 5, 2023
|
All of my comments above are not showstoppers; ACK. Feel free to respond to the above comments either in this PR or a later one. |
The cgroup-v1 init scripts, currently used by LabVIEW RT, interfere with other uses of cgroups (ex. containers, systemd) and are run at boot regardless if LV RT is installed or not. Selectively run the 'nicreatecpuacctgroups' and 'nicreatecpusets' init scripts only if cgroup-v1 is in use by LabVIEW RT. Currently cgroup-v1 is considered "in use" if LabVIEW RT is installed. This will change at a future date when LV RT adds cgroup-v2 support. Additionally the new '/etc/default/lvrt-cgroup' configuration script can be used to force set the LVRT_CGROUP_VERSION to 0 and leave cgroups under OS control for testing. Please note that the technically better alternative to make LabVIEW RT depend and directly install these scripts (instead of including them in the base image) was rejected due to the high cost of patching previous LabVIEW releases. Signed-off-by: Gratian Crisan <gratian.crisan@ni.com>
gratian
force-pushed
the
dev/nilrt/master/kirkstone-cgroup-v1-detection
branch
from
c831bb6 to
9335712
Compare
Changes since V1
V2 Testing
|
|
👍🏻 |
|
@amstewart I've reset your vote as a reminder to review v2 and pull if it looks good to you. |
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cgroup-v1 init scripts, currently used by LabVIEW RT, interfere with other uses of cgroups (ex. containers, systemd) and are run at boot regardless if LV RT is installed or not.
Selectively run the 'nicreatecpuacctgroups' and 'nicreatecpusets' init scripts only if cgroup-v1 is in use by LabVIEW RT. Currently cgroup-v1 is considered "in use" if LabVIEW RT is installed. This will change at a future date when LV RT adds cgroup-v2 support.
Additionally the new '/etc/default/lvrt-cgroup' configuration script can be used to force set the LVRT_CGROUP_VERSION to 0 and leave cgroups under OS control for testing.
Please note that the technically better alternative to make LabVIEW RT depend and directly install these scripts (instead of including them in the base image) was rejected due to the high cost of patching previous LabVIEW releases.