nidaqmx: Use in-project virtualenvs #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Configure Poetry to use in-project virtualenvs.
Why should this Pull Request be merged?
This configuration is recommended in NI's internal "Python Getting Started" page and is used by some of NI's other GitHub repos.
Storing the virtualenv in the project's
.venvsubdirectory ensures that runninggit clean -dfxor deleting the local Git repo deletes the virtualenv.What testing has been done?
Ran
poetry build,poetry run pytest, andpoetry run toxand verified that they do a build, run tests, etc. (Some tests are failing on my test machine, but this doesn't seem related to venv location.)