Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digital Stream Writer tests #531

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented Mar 5, 2024

What does this Pull Request accomplish?

This ensures we have a test per method of the Digital stream writer classes. These tests use digital loopback to validate that the data made it all the way through the Python/C bindings correctly to the underlying driver.

other miscellany

Why should this Pull Request be merged?

This will give us confidence that we haven't broken anything as we refactor parts of the Python / C bindings.

What testing has been done?

> poetry run ni-python-styleguide fix tests && poetry run ni-python-styleguide lint tests && poetry run pytest -rs -k test_stream_writers_do
===================================== test session starts ======================================
platform win32 -- Python 3.9.13, pytest-8.0.2, pluggy-1.4.0
rootdir: C:\dev\nidaqmx-python
configfile: pyproject.toml
testpaths: tests
plugins: cov-4.1.0, mock-3.12.0
collected 1951 items / 1897 deselected / 54 selected

tests\component\test_stream_writers_do.py ............................................... [ 87%]
.......                                                                                   [100%]

============================= 54 passed, 1897 deselected in 18.00s =============================

(I also checked test_stream_writers_ao and test_stream_readers_di for the minor fixes there.)

@zhindes zhindes marked this pull request as ready for review March 5, 2024 23:31
Copy link

github-actions bot commented Mar 6, 2024

Test Results

    30 files  ±    0      30 suites  ±0   37m 8s ⏱️ - 1m 21s
 2 004 tests +   74   1 667 ✅ + 12    337 💤 + 62  0 ❌ ±0 
31 740 runs  +1 060  26 810 ✅ +170  4 930 💤 +890  0 ❌ ±0 

Results for commit f0e5a5b. ± Comparison against base commit df7366e.

♻️ This comment has been updated with latest results.

tests/component/test_stream_writers_do.py Outdated Show resolved Hide resolved
tests/component/test_stream_writers_do.py Outdated Show resolved Hide resolved
tests/component/test_stream_writers_do.py Outdated Show resolved Hide resolved
@zhindes zhindes requested a review from bkeryan March 6, 2024 16:44
@zhindes zhindes merged commit 2c18e56 into master Mar 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants