-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix physical channel/device collection slice/string behavior #536
Conversation
Test Results 34 files ± 0 34 suites ±0 43m 15s ⏱️ + 1m 8s Results for commit a9a8a79. ± Comparison against base commit 2e0e590. This pull request removes 32 and adds 192 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
src/handwritten/system/_collections/physical_channel_collection.py
Outdated
Show resolved
Hide resolved
5d93c2a
to
a9a8a79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
What does this Pull Request accomplish?
Fixes string and slice behavior of Physical Channel Collection to match that of Device Collection
New behaviorFor both Physical Channel and Device - raiseKeyError
if a string is provided that doesn't match the collectionWhy should this Pull Request be merged?
Closes #392
What testing has been done?
Added new tests. Fixed existing tests that used the name of an invalid PhysicalChannel object to use the
channel_names
property of the collection instead.