Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update cal date check to pass on older devices #648

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Oct 17, 2024

What does this Pull Request accomplish?

Update the cal date check in test_device_properties.py to accept 2009 as a valid date.

Why should this Pull Request be merged?

X Series was released in 2009. My test machine has an X Series from 2009 that has never been recalibrated.

What testing has been done?

Works on my machine.

Copy link

Test Results

    38 files  ±0      38 suites  ±0   58m 10s ⏱️ -47s
 2 348 tests ±0   1 994 ✅ ±0    354 💤 ±0  0 ❌ ±0 
46 232 runs  ±0  39 434 ✅ ±0  6 798 💤 ±0  0 ❌ ±0 

Results for commit b59ddd3. ± Comparison against base commit dab722c.

@bkeryan bkeryan merged commit 631ee8f into master Oct 17, 2024
19 checks passed
@bkeryan bkeryan deleted the users/bkeryan/xseries-cal-date-check branch October 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants