-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column IDs to table #1033
Merged
Merged
Add column IDs to table #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
requested review from
rajsite,
jattasNI,
atmgrifter00 and
msmithNI
as code owners
February 7, 2023 18:04
rajsite
reviewed
Feb 7, 2023
jattasNI
approved these changes
Feb 8, 2023
rajsite
reviewed
Feb 8, 2023
packages/nimble-components/src/table/models/table-validator.spec.ts
Outdated
Show resolved
Hide resolved
msmithNI
approved these changes
Feb 8, 2023
atmgrifter00
reviewed
Feb 9, 2023
packages/nimble-blazor/NimbleBlazor/Components/NimbleTableColumnText.razor.cs
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Feb 9, 2023
rajsite
approved these changes
Feb 9, 2023
packages/nimble-components/src/table/models/table-validator.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Columns in the table should have IDs to reference them. These IDs will likely be used in a few different APIs in the future (e.g. sorting), but immediately, these IDs will be used in the events emitted when an action menu toggles.
👩💻 Implementation
column-id
on a columncolumn-id
is either not specified for all columns or is uniquely specified for all columnscolumn-id
of any column changes, I needed to add notifiers to each column.🧪 Testing
✅ Checklist