Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column IDs to table #1033

Merged
merged 31 commits into from
Feb 14, 2023
Merged

Add column IDs to table #1033

merged 31 commits into from
Feb 14, 2023

Conversation

mollykreis
Copy link
Contributor

@mollykreis mollykreis commented Feb 7, 2023

Pull Request

🤨 Rationale

Columns in the table should have IDs to reference them. These IDs will likely be used in a few different APIs in the future (e.g. sorting), but immediately, these IDs will be used in the events emitted when an action menu toggles.

👩‍💻 Implementation

  • Add ability to specify a column-id on a column
  • Add validation that ensures that the column-id is either not specified for all columns or is uniquely specified for all columns
    • Note: In order to re-run validation on the column IDs when the column-id of any column changes, I needed to add notifiers to each column.
  • Extend Blazor & Angular components/types

🧪 Testing

  • Manually tested in storybook, Angular example app, and Blazor example app
  • Wrote new unit tests

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis mollykreis requested a review from rajsite February 8, 2023 20:59
@mollykreis mollykreis merged commit a88731d into main Feb 14, 2023
@mollykreis mollykreis deleted the table-column-ids branch February 14, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants