Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table row grouping #1139

Merged
merged 47 commits into from
Apr 6, 2023
Merged

Table row grouping #1139

merged 47 commits into from
Apr 6, 2023

Conversation

atmgrifter00
Copy link
Contributor

@atmgrifter00 atmgrifter00 commented Mar 29, 2023

Pull Request

🤨 Rationale

👩‍💻 Implementation

Following the mixin pattern for fractional width columns, I have created a mixin for allowing columns to opt in to being groupable.

To render the group row, I have created a TableGroupRow component, which encapsulates the expand/collapse button as well as the rendered visual representing the grouped value, as well as the count of the number of rows "parented" under the group row.

This PR does not include:

  • Angular/Blazor integration
  • Keyboard navigation
  • Updated row stylings for hover states
  • Styling/layout changes related to the presence of a "collapse-all" button in the header (which will be added later).

🧪 Testing

Unit tests.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback on the story and component behavior; haven't looked at the code yet.

Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick initial feedback post-refactor from playing with the storybook. Will review the new code tomorrow (possibly after you've addressed Molly's feedback).

@atmgrifter00 atmgrifter00 merged commit b7fbb73 into main Apr 6, 2023
@atmgrifter00 atmgrifter00 deleted the table-row-grouping branch April 6, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants