-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table row grouping #1139
Table row grouping #1139
Conversation
packages/nimble-components/src/table/components/group-row/styles.ts
Outdated
Show resolved
Hide resolved
change/@ni-nimble-angular-80df5684-7189-4a21-baf5-76ca8f95d406.json
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/base/tests/table-column.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/base/tests/table-column.stories.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial feedback on the story and component behavior; haven't looked at the code yet.
packages/nimble-components/src/table-column/base/tests/table-column.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/base/tests/table-column.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text/group-header/template.ts
Outdated
Show resolved
Hide resolved
change/@ni-nimble-components-5d2fb5bc-c468-4393-ac6d-303d592b03c8.json
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/mixins/tests/groupable-column.spec.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text/group-header/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text/group-header/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/components/group-header-view/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some quick initial feedback post-refactor from playing with the storybook. Will review the new code tomorrow (possibly after you've addressed Molly's feedback).
packages/nimble-components/src/table-column/base/tests/table-column.stories.ts
Show resolved
Hide resolved
packages/nimble-components/src/table/components/cell/template.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text/group-header/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/components/group-row/tests/table-group-row.pageobject.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text/tests/table-column-text.spec.ts
Show resolved
Hide resolved
…index.ts Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
…o table-row-grouping
Pull Request
🤨 Rationale
👩💻 Implementation
Following the mixin pattern for fractional width columns, I have created a mixin for allowing columns to opt in to being groupable.
To render the group row, I have created a
TableGroupRow
component, which encapsulates the expand/collapse button as well as the rendered visual representing the grouped value, as well as the count of the number of rows "parented" under the group row.This PR does not include:
🧪 Testing
Unit tests.
✅ Checklist