Fork number-field and text-field templates #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
commented
Dec 12, 2024
packages/nimble-components/src/number-field/tests/number-field.foundation.spec.ts
Outdated
Show resolved
Hide resolved
mollykreis
commented
Dec 12, 2024
|
@msmithNI, will you buddy this PR for me? |
1 task
msmithNI
approved these changes
Dec 12, 2024
packages/nimble-components/src/number-field/tests/number-field.foundation.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Jan 3, 2025
mollykreis
added a commit
that referenced
this pull request
Jan 6, 2025
…2496) # Pull Request ## 🤨 Rationale Add `required-visible` attributes to the radio-group, select, combobox, and text-area components as part of #2100. There is still a need to add this attribute to the text-field and number-field. That will be done once the templates for those components have been forked (#2495). ## 👩💻 Implementation Within the `patterns` directory, I created a mixin that can be used on elements that should have a `requiredVisible` property and `required-visible` attribute. Additionally, shared styling was added for the `requiredVisible` state and a function was created to generate the template for an element's label. This is a function rather than a constant template because each element already had an existing label structure that I didn't want to change as part of this PR. The template of each element included in this PR was also updated to set `aria-required` based on the value of `requiredVisible`. I also updated the styling of icons to solve a problem I encountered when shrinking the asterisk icon down to 5x5. ## 🧪 Testing - Manually tested - New matrix tests - Unit tests for the new mixin - New unit tests for the ARIA behavior of each element ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fork the FAST templates for the number-field and the text-field in preparation for adding a required-visible icon to the label (see #2100)
👩💻 Implementation
Forked the FAST templates for the number-field and the text-field with no functional changes.
🧪 Testing
Verified tests still pass and no visual changes were introduced to those components.
✅ Checklist