Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Angular directive for nimble-table #914

Merged
merged 26 commits into from
Dec 14, 2022
Merged

Conversation

mollykreis
Copy link
Contributor

Pull Request

🀨 Rationale

Create an Angular directive for the table, so that it can be used within Angular.

This is part of #840.

πŸ‘©β€πŸ’» Implementation

  • Create an Angular directive for the nimble-table that allows binding data to the data property on the table.
  • Add a table to the example Angular app.
  • Updated component status table to reflect that experimental Angular support now exists for the nimble-table

πŸ§ͺ Testing

  • Create unit tests for the Angular directive following the same pattern as other unit tests in Angular
    • I did not write a test for "with template string values" since I didn't think it made sense to write a test for hard-coding an array in the template
    • I did not write a test for "with attribute bound values" since data is not an attribute on the nimble-table web component

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis mollykreis enabled auto-merge (squash) December 14, 2022 14:32
@mollykreis mollykreis merged commit c1b0926 into main Dec 14, 2022
@mollykreis mollykreis deleted the initial-table-angular branch December 14, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants