-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create nimble-table-row and nimble-table-cell and use them in the table #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
reviewed
Dec 14, 2022
rajsite
reviewed
Dec 14, 2022
jattasNI
approved these changes
Dec 14, 2022
atmgrifter00
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This PR creates the
nimble-table-row
andnimble-table-cell
elements, which will only be used within thenimble-table
, not as stand-alone elements exported fromnimble-components
. The property types on these elements will likely change moving forward, but creating the elements is a step closer to the correct structure of the DOM and separation of logic between the table, rows, and cells.This PR also adds ARIA roles for a table.
This is part of #840.
👩💻 Implementation
nimble-table-row
row
nimble-table-cell
cell
I think we will also create an element to represent a column header, but that was not in the scope of this PR.
🧪 Testing
nimble-table-row
and thenimble-table-cell
because we determined in an offline conversation that they did not seem necessary at this point in time. Until the need arises, we will plan to test table functionality with unit tests on the table itself, not its sub-elements.✅ Checklist